Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system_clock is NOT monotonic, and we should use steady_clock instead #2

Merged
merged 1 commit into from
Oct 21, 2019
Merged

system_clock is NOT monotonic, and we should use steady_clock instead #2

merged 1 commit into from
Oct 21, 2019
+16 −16

Conversation

sewenew
Copy link
Contributor

@sewenew sewenew commented Oct 20, 2019

  1. use steady_clock instead of system_clock. steady_clock is monotonic and suitable for measuring intervals.
  2. refactor the Timer implementation to remove duplicate code.

@zehuanw zehuanw merged commit f251b55 into NVIDIA-Merlin:master Oct 21, 2019
@zehuanw
Copy link
Collaborator

zehuanw commented Oct 21, 2019

Good point! Thank you for your contribution! I slightly modified your pull request and merged in to our master branch.

zehuanw pushed a commit that referenced this pull request Feb 2, 2021
Fix building issue #2
99f2548
mikemckiernan pushed a commit that referenced this pull request Nov 28, 2022
Fix building issue #2
17b3668
@dusir dusir mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sewenew @zehuanw